[
https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494994#comment-14494994
]
ASF GitHub Bot commented on THRIFT-3088:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/432#discussion_r28375520
--- Diff: lib/java/src/org/apache/thrift/server/TThreadPoolServer.java ---
@@ -303,6 +303,10 @@ public void run() {
if (outputTransport != null) {
outputTransport.close();
}
+
+ if (client_.isOpen()) {
--- End diff --
Does TSimpleServer in java need the same change?
> TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
> -----------------------------------------------------------
>
> Key: THRIFT-3088
> URL: https://issues.apache.org/jira/browse/THRIFT-3088
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9
> Reporter: Winger Pun
>
> Start TThreadPoolServer to server with TSaslServerTransport.Factory as
> transportFactory. While using nc to test the specified port whether
> reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket
> at once while successful connect TThreadPoolServer, but the server still try
> using sasl protocol to build an inputTransport which of course failed at
> once. However inputTransport is null which makes it can't close socket
> properly which lead to CLOSE_WAIT socket.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
