GitHub user sharpdevel reopened a pull request:

    https://github.com/apache/thrift/pull/377

    Issue with IPv6 an IPv4 on windows machines

    When using TcpListener and TcpClient it depends on the network 
configuration if IPv4 or IPv6 is used. By upgrading the framework to .NET 4.5 
the DualMode can be set on the sockets of the listener and the client. The 
sockets then try to estabild IPv6 sockets before they fallback to IPv4. For 
example IPv4 is preferred on Windows 7 machines while on Windows 8 and 8.1 
machines IPv6 is preferred. This patch works on Window 7, 8 and 8.1.
    
    Additionally the AssemblyFileVersion must not contain an asterix. By 
removing the AssemblyFileVersion it alsways corresponds the the generated value 
of AsemblyVersion
    
    In the PreBuild command of the ThriftTest project I added "" around the 
MSBuildToolPath to make the script work on english windows machine wheren the 
folder equals to sth like "C:\program files\....."


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sharpdevel/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #377
    
----
commit 9bed8db267bf4b48cc9d6dd5d0a809d83e1e2fb1
Author: sharpdevel <icode666@github>
Date:   2015-02-13T12:19:44Z

    - When using TcpListener and TcpClient it depends on the network 
configuration if IPv4 or IPv6 is used. By upgrading the framework to .NET 4.5 
the DualMode can be set on the sockets of the listener and the client. The 
sockets then try to estabild IPv6 sockets before they fallback to IPv4

commit 7704ab0ce8e9dfa180d5351ffdd3e4065b09fa95
Author: sharpdevel <icode666@github>
Date:   2015-02-26T12:45:57Z

    TcpListener and TcpClient are created based on the capabilities of the used 
runtime framework. For windows the changes automatically handle IPv4 and IPv6 
sockets. In mono it behaves as before.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to