[
https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499935#comment-14499935
]
ASF GitHub Bot commented on THRIFT-2640:
----------------------------------------
Github user jeremy-w commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94001001
It would be nice if this built cleanly with the following warning config:
`OTHER_CFLAGS = -Wall -Wextra -Weverything -Wno-objc-missing-property-synthesis
-Wno-unused-parameter -Wno-auto-import -Wno-documentation-unknown-command
-Wno-direct-ivar-access -Wno-objc-interface-ivars -fno-objc-arc`
This finds a lot of implicit conversion and ARC issues. Many of those are
due to TProtocol.h not being updated similarly to TBinaryProtocol.h to avoid
unnecessary indirect returns (and, under ARC, the need for `__autoreleasing`),
like `- (void) readStructBeginReturningName: (NSString **) name;` which could
simply return the name directly.
I know that's a pain though, and I don't want to hold up adding a compact
protocol, so we could add an issue to fix this up in a later PR. (More
generally, we really need an actual Xcode project with consistent build
configuration, and actual protocol tests.)
> Compact Protocol in Cocoa
> -------------------------
>
> Key: THRIFT-2640
> URL: https://issues.apache.org/jira/browse/THRIFT-2640
> Project: Thrift
> Issue Type: Sub-task
> Components: Cocoa - Library
> Affects Versions: 0.9.1
> Reporter: Mark Hornsby
> Assignee: Jens Geyer
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
