[ https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503602#comment-14503602 ]
Ben Craig commented on THRIFT-2119: ----------------------------------- I am fine dropping this as well. I will close. NOTE: http://wxwidgets.blogspot.com/2014/08/msvs-versions-poll-results.html Combined share of VS2005, VS2003, and MSVC6 is 6%. VS2005 is 3.2%. Those numbers are low enough to justify this... assuming that wxwidgets clients are similar to our clients. > Compiling the Thrift C++ Library with Visual Studio 2005 > -------------------------------------------------------- > > Key: THRIFT-2119 > URL: https://issues.apache.org/jira/browse/THRIFT-2119 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.9.1, 1.0 > Environment: Microsoft Visual Studio 2005. > Reporter: Jonas > Labels: patch > Attachments: CMakeLists.txt, thrift_patch.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Hi, > I created a patch (for the current trunk revision) to compile the Thrift C++ > Library with Visual Studio 2005 (only libthrift, not libthriftnb for > asynchronous calls). > The patch essentially adds a few (forgotten?) #ifdef HAVE_STDINT_H and > contains a workaround for a problem with SFINAE with the VS8 compiler. > An additional problem appears with tr1::function when compiling > TAsyncChannel.cpp. I excluded this source file from the build (it is > required?). > Could these changes be integrated in the trunk? > Many thanks for your considerations, > Best, > Jonas -- This message was sent by Atlassian JIRA (v6.3.4#6332)