Github user jeroenvlek commented on the pull request:

    https://github.com/apache/thrift/pull/213#issuecomment-95121808
  
    The commit 3b4b03e introduces a conversion to bytearray in 
TBinaryProtocol.writeString():
    
    
    ```python
    # after commit 3b4b03e and 3d912d7
    def writeString(self, str):
      encoded = bytearray(str, 'utf-8')
      self.writeI32(len(encoded))
      self.trans.write(encoded)
    
    # before
    def writeString(self, str):
      self.writeI32(len(str))
      self.trans.write(str)
    ```
    
    This causes problems for people trying to write byte strings. See for 
example here: https://github.com/wbolster/happybase/issues/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to