Github user henrique commented on a diff in the pull request:
https://github.com/apache/thrift/pull/456#discussion_r29022002
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -576,12 +576,12 @@ int TSSLSocketFactory::passwordCallback(char*
password, int size, int, void* dat
TSSLSocketFactory* factory = (TSSLSocketFactory*)data;
string userPassword;
factory->getPassword(userPassword, size);
- int length = userPassword.size();
+ std::string::size_type length = userPassword.size();
if (length > size) {
--- End diff --
Don't you get a signed vs unsigned warning here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
