[
https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510424#comment-14510424
]
ASF GitHub Bot commented on THRIFT-2850:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/456#discussion_r29022096
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -576,12 +576,12 @@ int TSSLSocketFactory::passwordCallback(char*
password, int size, int, void* dat
TSSLSocketFactory* factory = (TSSLSocketFactory*)data;
string userPassword;
factory->getPassword(userPassword, size);
- int length = userPassword.size();
+ std::string::size_type length = userPassword.size();
if (length > size) {
--- End diff --
std::string::size_time is the same as the return value of
std::string::size(), which is potentially different than "int" (on Windows this
was a compiler warning), which is why I changed it to quiet the warnings. It
is more correct now.
> CMake for Apache Thrift
> -----------------------
>
> Key: THRIFT-2850
> URL: https://issues.apache.org/jira/browse/THRIFT-2850
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Environment: all platforms
> Reporter: Roger Meier
> Assignee: Roger Meier
> Labels: cmake, travis
> Attachments: 0001-THRIFT-2850-CMake-for-Apache-Thrift.patch
>
>
> Goal: Extend Apache Thrift's *make cross* approach to the build system.
> Due to growing the field of operating system support, a proper executable
> and library detection mechanism running on as much platforms as possible
> becomes required. The other aspect is simplify the release process and
> package generation process.
> As nice side benefit of CMake is the generation of development environment
> specific solution files(VisualStudio, Eclipse, Xcode, etc. ). => No solution
> files within source tree.
> We are already building Apache Thrift with CMake for Linux-ARM, Linux-x86,
> Windows CE and Windows.
> We are in preparation phase for a pull request here:
> https://github.com/siemens/thrift/commits/cmake-master
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
