GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/460
bugfix/THRIFT-3081 consolidate client processing loops in simple and threaded servers This provides consistency to client handling throughout the client lifecycle across all the simple and threaded servers, and improves maintainability. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3081-on-THRIFT-2441 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/460.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #460 ---- commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit 44713020d03c38776432642d0798ea8d9f3e4168 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-05T16:32:03Z [THRIFT-3081] consolidate C++ client processing loops commit 3cc72ce101f2214b5b9698473523a93820219388 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-06T15:10:50Z Merge branch 'master' of https://github.com/apache/thrift into bugfix/THRIFT-3081-consolidate-client-processing-loops commit c53d11879cc25bf6a8dfb4a5961be4f86da9c715 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-09T16:32:02Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-3081-consolidate-client-processing-loops commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit e5e6a2bdbd0ce344be8456dd20e15fa7940b07a0 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T11:56:39Z THRIFT-3081 address code review concerns commit e3a5bcd4737d3497f8b256c8fb2988388cb1303d Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T12:00:06Z THRIFT-3081 remove unnecessary code commit c64eab0d5e90a732195b459d41fbce32af356b4d Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T12:01:49Z THRIFT-3081 remove virtual dtor impl in header commit 98783be50ddac6c01294bf0957fc9cf73c6ba169 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T14:21:19Z THRIFT-3081 consolidate client processing loop commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET commit 05878bcab37c77b49d380faa9a110c43124bc9ce Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T10:45:52Z Merge branch 'bugfix/THRIFT-2441-disconnect-clients-on-server-stop' into bugfix/THRIFT-3081-on-THRIFT-2441 commit 576688b28300b5e3366329a0d21e828fe990a3c1 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T11:06:45Z THRIFT-3081 fix client processing loop termination commit 49153dd33b63d054c72d6e28e5048b2ee80e5cf6 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T11:12:46Z THRIFT-2441 fix cmake error with new integration test using EmptyService commit e9997d921b7d864bee19ba0b9cf5bb27eb817594 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T11:45:49Z THRIFT-2441 fix cmake build and enhance TServerIntegrationTest to test more code paths commit 4e0570bb6eb4a5603728c0951749ca02367ee5f7 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T11:48:24Z Merge branch 'bugfix/THRIFT-2441-disconnect-clients-on-server-stop' into bugfix/THRIFT-3081-on-THRIFT-2441 commit 35144b0534ee45a27914d445cf8ac8997a732e99 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T11:56:48Z THRIFT-3081 optimize error handling in client loop (check most common exception type first) commit 77a47041fe1296588796c5256b33e3a08ec5a587 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-22T05:06:02Z THRIFT-2441 fix test compilation on windows commit b1418317a0ebe6150efd0fe2339fefc4ac2091c6 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-22T13:08:52Z fix windows link warning ignoring -lrt commit f6803bf779c1e6ac71d17d4a972fb10921a1658a Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-22T13:28:17Z Merge branch 'master' into bugfix/THRIFT-2441-disconnect-clients-on-server-stop Conflicts: lib/cpp/test/TServerSocketTest.cpp commit fdaead2180fd0c187663bc20f2f63b97277ea6b2 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-24T10:50:56Z Merge branch 'master' into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 994ab49da77f9363bc11ec67114502297e4cba65 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-24T14:47:08Z Merge branch 'bugfix/THRIFT-2441-disconnect-clients-on-server-stop' into bugfix/THRIFT-3081-on-THRIFT-2441 ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---