[
https://issues.apache.org/jira/browse/THRIFT-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512975#comment-14512975
]
Jens Geyer commented on THRIFT-3114:
------------------------------------
GitHub user xli2012 opened a pull request:
https://github.com/apache/thrift/pull/463
Thrift 3114
Using local temp variables to not pollute the global table.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xli2012/thrift THRIFT-3114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #463
----
commit 4ef9028be8f1a132f44e3611043c467962431d1c
Author: Xin Li <lixin....@gmail.com>
Date: 2015-04-25T19:46:29Z
THRIFT-3114 Using local temp variables to not pollute the global table
commit 581559020a5a324199d3f993a3c7ff9208085b90
Author: Xin Li <lixin....@gmail.com>
Date: 2015-04-25T19:54:41Z
refactor default arguments
----
> Using local temp variables to not pollute the global table
> ----------------------------------------------------------
>
> Key: THRIFT-3114
> URL: https://issues.apache.org/jira/browse/THRIFT-3114
> Project: Thrift
> Issue Type: Improvement
> Components: Lua - Compiler
> Affects Versions: 1.0
> Environment: Mac OS X 10.9.5, Lua 5.2
> Reporter: Xin Li
>
> Should prefix the field deserialization statements with "local" whenever the
> output is a temporary variable, for example this compiler output:
> _elem46 = iprot:readI32()
> should be changed to:
> local _elem46 = iprot:readI32().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
