[
https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513012#comment-14513012
]
ASF GitHub Bot commented on THRIFT-3081:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/464
THRIFT-3081 consolidate client processing loop in most TServers
This pull request consolidates the client processing loop in the
TSimpleServer, TThreadedServer, and TThreadPoolServer. This ensures the
servers all handle clients in the same way including in error paths, and
improves project maintainability by consolidating similar code paths.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT-3081-cherry-picked-after-THRIFT-2441-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/464.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #464
----
commit 5e334132784492369ae2316aae562b7ca965e467
Author: Jim King <jim.k...@simplivity.com>
Date: 2015-04-26T11:52:40Z
THRIFT-3081 consolidate client processing loop in Simple, Threaded, and
Thread Pool servers
----
> C++ Consolidate client processing loops in TServers
> ---------------------------------------------------
>
> Key: THRIFT-3081
> URL: https://issues.apache.org/jira/browse/THRIFT-3081
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2
> Reporter: James E. King, III
>
> Currently each of TSimpleServer, TThreadedServer, and TThreadPoolServer have
> their own very similar but not quite identical way of processing a client's
> lifetime. The code has been copied around and changed; for example a
> TThreadPoolServer handles TTransportExceptions from process() differently
> than a TThreadedServer does.
> There are certain requirements for this processing loop that needs to be met
> by every client. Consolidating these three disparate implementations of the
> client processing loop into one will provide consistency as well as easier
> maintenance, as there will be one common client processing loop that will
> contain all the logic from {{eventHandler->createContext}} through
> {{client->close}}.
> It was also discovered that all three implementations call peek() in each
> loop which causes more recv calls than are really needed. Will experiment
> with removing peek entirely; expectation is that it is sufficient to have
> exception handling around process() and/or have process() return false to end
> the processing loop, and peek() is likely an unnecessary temporary band-aid
> that got left there.
> This was inspired by changes in THRIFT-2441 and I was encouraged to make this
> a separate body of work from that change so that it can be reviewed in
> isolation from other changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
