[
https://issues.apache.org/jira/browse/THRIFT-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513088#comment-14513088
]
ASF GitHub Bot commented on THRIFT-3117:
----------------------------------------
GitHub user Smyatkin-Maxim opened a pull request:
https://github.com/apache/thrift/pull/465
THRIFT-3117 Java TSSLTransportFactory can't load certificates within JAR...
Added getStoreAsStream function to look for certificates in filesystem
paths, URLs or classpath resources just like it is done in ActiveMQ.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Smyatkin-Maxim/thrift THRIFT-3117
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/465.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #465
----
commit aa6d693b21ccc855921a23f507fbb367b91da2c4
Author: Smyatkin Maxim <smyatkinma...@gmail.com>
Date: 2015-04-26T15:07:26Z
THRIFT-3117 Java TSSLTransportFactory can't load certificates within JAR
archive
----
> Java TSSLTransportFactory can't load certificates within JAR archive
> --------------------------------------------------------------------
>
> Key: THRIFT-3117
> URL: https://issues.apache.org/jira/browse/THRIFT-3117
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9.2
> Reporter: Smyatkin Maxim
> Priority: Trivial
> Fix For: 0.9.2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> TSSLTransportFactory's setKeyStore/setTrustStore accept only plain file
> system paths what makes it impossible to use URL's or classpath based
> resources. E.g., I didn't find a way to load certificate from JAR.
> I propose to look for both URLs and resources if the file can not be found by
> the given path. It's how it is done in ActiveMQ:
> https://access.redhat.com/documentation/en-US/Fuse_ESB/4.4.1/html/ActiveMQ_Security_Guide/files/SSL-SecureJavaClients.html
> https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/ActiveMQSslConnectionFactory.java#L175-L206
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
