Hey Henrique, I also think this is a good commit for now.
Down the road, if all protocols are expected to have a valid media type, it would be nice to have something like a GetMediaType() method in TProtocol (across languages) to support headers and other dependent features. -Randy On Thu, Apr 30, 2015 at 7:23 AM, Roger Meier (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521557#comment-14521557 > ] > > Roger Meier commented on THRIFT-2674: > ------------------------------------- > > Henrique, I think you can commit this. > > > JavaScript: declare Accept: and Content-Type: in request > > -------------------------------------------------------- > > > > Key: THRIFT-2674 > > URL: https://issues.apache.org/jira/browse/THRIFT-2674 > > Project: Thrift > > Issue Type: Bug > > Components: JavaScript - Library > > Reporter: Stig Bakken > > Priority: Minor > > Attachments: js-type.diff > > > > > > When a JS client communicates with a backend supporting several > encodings, knowing which protocol to use is a bit kludgy. This patch tries > to fix that by always setting the Accept: and Content-Type: request headers > to "application/json". > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
