[
https://issues.apache.org/jira/browse/THRIFT-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528077#comment-14528077
]
ASF GitHub Bot commented on THRIFT-3126:
----------------------------------------
GitHub user stigsb opened a pull request:
https://github.com/apache/thrift/pull/479
PHP Generator: fix JSON encoding of empty maps and maps with int keys
Tracked by THRIFT-3126
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stigsb/thrift THRIFT-3126
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #479
----
commit 68253ccb483e8f80dc6febace6765f526abf1a46
Author: Stig Bakken <s...@zedge.net>
Date: 2015-05-05T07:35:17Z
PHP Generator: fix JSON encoding of empty maps and maps with int keys
----
> PHP JSON serializer converts empty or int-indexed maps to lists
> ---------------------------------------------------------------
>
> Key: THRIFT-3126
> URL: https://issues.apache.org/jira/browse/THRIFT-3126
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
> Affects Versions: 0.9.2
> Reporter: Stig Bakken
> Priority: Minor
>
> Because of PHP's idiosyncratic arrays, you can't tell the difference between
> an empty array and empty associative array (they are the same), or between a
> thrift map with integer indexes and a list. Fix attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
