[ https://issues.apache.org/jira/browse/THRIFT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James E. King, III reassigned THRIFT-2150: ------------------------------------------ Assignee: James E. King, III > Should windows/config.h define WIN32_LEAN_AND_MEAN? > --------------------------------------------------- > > Key: THRIFT-2150 > URL: https://issues.apache.org/jira/browse/THRIFT-2150 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.9.1 > Environment: MSVC > Reporter: Chris Stylianou > Assignee: James E. King, III > Labels: c++, msvc, thrift, windows > > As "windows/config.h" includes Winsock2.h, is it not best practise to define > before it: > {code}WIN32_LEAN_AND_MEAN{code} > This is in case someone includes Windows.h, which automatically includes the > incompatible Winsock.h. It also reduces the size of the Win32 header files > which helps compilation speeds :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)