[
https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531120#comment-14531120
]
ASF GitHub Bot commented on THRIFT-3130:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/483
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF
Testing proved it was unnecessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/remove-thrift-overload-if-unnecessary
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit 6dadd7b06b8643659cc38a226f05714bad1f50f3
Author: Jim King <jim.k...@simplivity.com>
Date: 2015-05-06T18:25:28Z
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF as testing proved it
unnecessary
----
> Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316
> ---------------------------------------------------------------
>
> Key: THRIFT-3130
> URL: https://issues.apache.org/jira/browse/THRIFT-3130
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> In THRIFT-1316 some macros were added that have proven to be unnecessary.
> They were partially eliminated in THRIFT-3083, and this traces the removal of
> what was left. In addition, TOutput was moved to its own class, and since
> TThrift.cpp only contained TOutput code, it was renamed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
