[
https://issues.apache.org/jira/browse/THRIFT-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546203#comment-14546203
]
Hudson commented on THRIFT-3149:
--------------------------------
SUCCESS: Integrated in Thrift #1549 (See
[https://builds.apache.org/job/Thrift/1549/])
THRIFT-3149 go: make generated readFieldN methods private (jensg: rev
b7138acd86cebee62bd4606ed2dc01901f042f5b)
* compiler/cpp/src/generate/t_go_generator.cc
* lib/go/thrift/serializer_types.go
> Make ReadFieldN methods in generated Go code private
> ----------------------------------------------------
>
> Key: THRIFT-3149
> URL: https://issues.apache.org/jira/browse/THRIFT-3149
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Konstantin Shaposhnikov
> Assignee: Konstantin Shaposhnikov
> Fix For: 0.9.3
>
>
> The go thrift compiler generates ReadFieldN and writeFieldN methods for every
> field of a struct. E.g.:
> {code}
> func (p *Statistics) ReadField1(iprot thrift.TProtocol) error {
> ...
> }
> func (p *Statistics) writeField1(oprot thrift.TProtocol) (err error) {
> ...
> }
> {code}
> ReadField1, ReadField2, etc are not very descriptive names and shouldn't be
> part of public API of a generated package (like writeFieldN).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
