[ 
https://issues.apache.org/jira/browse/THRIFT-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546557#comment-14546557
 ] 

ASF GitHub Bot commented on THRIFT-3157:
----------------------------------------

GitHub user roshan opened a pull request:

    https://github.com/apache/thrift/pull/498

    THRIFT-3157 Make TBase signature more explicit

    This doesn't look like it should break anything.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/roshan/thrift 
THRIFT-3157_more_explicit_tbase_signature

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #498
    
----
commit 67174465d8c624e1e8dfac35a704c803420ec766
Author: Roshan George <ros...@arjie.com>
Date:   2015-05-16T04:52:06Z

    Make TBase signature more explicit

----


> TBase signature should be TBase<T extends TBase<T,F>, F extends TFieldIdEnum>
> -----------------------------------------------------------------------------
>
>                 Key: THRIFT-3157
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3157
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.2
>            Reporter: Roshan George
>            Priority: Minor
>
> Is there any reason this isn't the case? The wildcarding doesn't appear to 
> give us anything extra. I've been told that it may help with uses of the 
> Comparable. Can anyone think of a use?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to