[
https://issues.apache.org/jira/browse/THRIFT-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552424#comment-14552424
]
ASF GitHub Bot commented on THRIFT-3169:
----------------------------------------
GitHub user kostya-sh opened a pull request:
https://github.com/apache/thrift/pull/506
THRIFT-3169 go: do not export thrift.TestEnum and thrift.TestStruct
Rename serializer_types.go to serializer_types_test.go so it is only used by
'go test'.
Rename TestEnum to MyTestEnum and TestStruct to MyTestStruct as methods like
TestEnumFromString confuse 'go test' (all TestXXX methods are test methods).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kostya-sh/thrift THRIFT-3169
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/506.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #506
----
commit 38273796487ff4e7f12781f05ed3f3e345511d4f
Author: Konstantin Shaposhnikov <k.shaposhni...@gmail.com>
Date: 2015-05-20T14:49:34Z
THRIFT-3169 go: do not export thrift.TestEnum and thrift.TestStruct
Rename serializer_types.go to serializer_types_test.go so it is only used by
'go test'.
Rename TestEnum to MyTestEnum and TestStruct to MyTestStruct as methods like
TestEnumFromString confuse 'go test' (all TestXXX methods are test methods).
----
> Do not export thrift.TestStruct and thrift.TestEnum in thrift Go library
> -------------------------------------------------------------------------
>
> Key: THRIFT-3169
> URL: https://issues.apache.org/jira/browse/THRIFT-3169
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Konstantin Shaposhnikov
>
> TestEnum and TestStruct are used in the tests only and I believe they were
> exported by mistake.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
