[
https://issues.apache.org/jira/browse/THRIFT-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554483#comment-14554483
]
ASF GitHub Bot commented on THRIFT-3160:
----------------------------------------
GitHub user kostya-sh opened a pull request:
https://github.com/apache/thrift/pull/507
THRIFT-3160 go: make generated enum types implement TextMarshaler and…
… TextUnmarshaler
This will make encoding/json package use string representations of enum
types
instead of numbers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kostya-sh/thrift THRIFT-3160
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #507
----
commit 0b2d041af3b4929ffc7bddd81010147881e22af2
Author: Konstantin Shaposhnikov <[email protected]>
Date: 2015-05-21T15:04:10Z
THRIFT-3160 go: make generated enum types implement TextMarshaler and
TextUnmarshaler
This will make encoding/json package use string representations of enum
types
instead of numbers.
----
> Make generated go enums implement TextMarshaller and TextUnmarshaller
> interfaces
> --------------------------------------------------------------------------------
>
> Key: THRIFT-3160
> URL: https://issues.apache.org/jira/browse/THRIFT-3160
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Konstantin Shaposhnikov
>
> This will make JSON encoder/decoders use string representation instead of
> meaningless numbers.
> The new generated code will looks like:
> {code}
> func (p TestEnum) MarshalText() ([]byte, error) {
> return []byte(p.String()), nil
> }
> func (p *TestEnum) UnmarshalText(text []byte) error {
> x, err := TestEnumFromString(string(text))
> *p = x
> return err
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
