[ 
https://issues.apache.org/jira/browse/THRIFT-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590446#comment-14590446
 ] 

Jens Geyer edited comment on THRIFT-3193 at 6/17/15 7:58 PM:
-------------------------------------------------------------

{quote}
This causes issues in our automation which enforces that the generated files 
are always unchanged.
{quote}

I'm not sure (a) if I understand the issue completely, and (b) if it is a 
Thrift-related problem or more a problem with your specific CI. 

Especially I have a problem understanding why the generated files change, and, 
if they are expected to change, why the CI expects them not to change? 

If they are re-generated every time, then they will (at least) change whenever 
the IDL changes, or the Thrift compiler gets upgraded, or on other occasions 
that you may not be able to control entirely. 

However, if the generated files are considered being kind of "fixed", then what 
speaks against just putiing the generated files under source control and omit 
the generation step entirely?



was (Author: jensg):
{quote}
This causes issues in our automation which enforces that the generated files 
are always unchanged.
{quote}

I'm not sure (a) if I understand the issue completely, and (b) if it is a 
Thrift-related problem or more a problem with your specific CI. 

Especially I have a problem understanding why the generated files change, and 
if they are expected to change, why the CI expects them not to change? If they 
are re-generated every time then they will change whenever the IDL changes. If 
the are jind of "fixed", then what speaks against just putiing the generated 
files under source control and omit the generation step entirely?


> Option to supress date value in @Generated annotation
> -----------------------------------------------------
>
>                 Key: THRIFT-3193
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3193
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Vitali Lovich
>
> https://issues.apache.org/jira/browse/THRIFT-1813 added the \@Generated 
> annotation but didn't provide a way to turn off generating the date.  This 
> causes issues in our automation which enforces that the generated files are 
> always unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to