[ 
https://issues.apache.org/jira/browse/THRIFT-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590622#comment-14590622
 ] 

Vitali Lovich commented on THRIFT-3193:
---------------------------------------

In our system the generated files are considered semi-fixed.  We check them in. 
 However, we have a hard enforcement that the generated code must match the 
checked-in code; this ensures that someone doesn't forget to regenerate the 
thrift after changing the file.  This will fail every single day since we do 
this by regenerating the thrift & comparing against the checked-in version.  
I've put in a hacky workaround in my CI to strip out the date but it would be 
nice for Thrift to just omit it in the first place.  Alternatively, if you want 
to include the date, it should be based on a stable value (e.g. last-modified 
timestamp of the originating .thrift).

This also will cause issues for incremental builds even if you generate them 
on-the-fly since the generated thrift will have to be recompiled at the start 
of every day (regardless of whether anything changed) even if you incrementally 
rsync since the date will always be different.

> Option to supress date value in @Generated annotation
> -----------------------------------------------------
>
>                 Key: THRIFT-3193
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3193
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Vitali Lovich
>
> https://issues.apache.org/jira/browse/THRIFT-1813 added the \@Generated 
> annotation but didn't provide a way to turn off generating the date.  This 
> causes issues in our automation which enforces that the generated files are 
> always unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to