[ https://issues.apache.org/jira/browse/THRIFT-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599407#comment-14599407 ]
Jake Farrell commented on THRIFT-3200: -------------------------------------- hey [~beberg], we typically try and avoid breaking backwards compatibility, but if a feature is incomplete or does not match any of the other client library implementations then it makes sense to get it inline with everything else so cross communication works. Worth opening a quick discussion thread on the dev@ list and if no objections there than I do not see any reason to not proceed with a patch for this > JS and nodejs do not encode JSON protocol binary fields as base64 > ----------------------------------------------------------------- > > Key: THRIFT-3200 > URL: https://issues.apache.org/jira/browse/THRIFT-3200 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library, Node.js - Library > Affects Versions: 0.9.2 > Reporter: Adam Beberg > Fix For: 0.9.3 > > > Binary fields in the JSON protocol are base64 encoded in > cpp/go/java/rb/py/go/... All code with JSON implementations except javascript > and nodejs - which escape them as if they as strings (unfinished > implementation). This makes js/nodejs incompatable with any other languages > since JSON is their only supported protocol. To fix this js/nodejs need to be > corrected, but this will break backward compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)