Github user jparise commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/535#discussion_r33729457
  
    --- Diff: compiler/cpp/src/generate/t_erl_generator.cc ---
    @@ -55,6 +55,7 @@ class t_erl_generator : public t_generator {
         out_dir_base_ = "gen-erl";
     
         legacy_names_ = (parsed_options.find("legacynames") != 
parsed_options.end());
    +    use_maps_ = (parsed_options.find("usemaps") != parsed_options.end());
    --- End diff --
    
    I think `maps` would be a more consistent option name.  Similar existing 
options are `slots` (for Python) and `templates` (for C++), which don't include 
a **use** prefix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to