[
https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611068#comment-14611068
]
ASF GitHub Bot commented on THRIFT-3214:
----------------------------------------
Github user thecodeboss commented on a diff in the pull request:
https://github.com/apache/thrift/pull/535#discussion_r33730165
--- Diff: compiler/cpp/src/generate/t_erl_generator.cc ---
@@ -55,6 +55,7 @@ class t_erl_generator : public t_generator {
out_dir_base_ = "gen-erl";
legacy_names_ = (parsed_options.find("legacynames") !=
parsed_options.end());
+ use_maps_ = (parsed_options.find("usemaps") != parsed_options.end());
--- End diff --
Great catch @jparise, the PR has been modified with your suggestion.
> Add Erlang option for using maps instead of dicts
> -------------------------------------------------
>
> Key: THRIFT-3214
> URL: https://issues.apache.org/jira/browse/THRIFT-3214
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Compiler
> Reporter: Michael Oliver
> Assignee: Michael Oliver
> Priority: Minor
>
> Erlang OTP 18 introduces significant performance improvements when using maps
> instead of dicts. Here is a benchmark showing the gains:
> https://gist.github.com/BinaryMuse/bb9f2cbf692e6cfa4841
> Thrift should support an option for the Erlang compiler to produce maps
> instead of dicts, to take advantage of these performance improvements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
