[ 
https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612374#comment-14612374
 ] 

ASF GitHub Bot commented on THRIFT-3217:
----------------------------------------

GitHub user ben-craig opened a pull request:

    https://github.com/apache/thrift/pull/537

    THRIFT-3217: Added little endian binary protocol

    Benchmark results from my laptop:
    Write big endian: 524.562 kHz
     Read big endian: 328.188 kHz
    Write little endian: 688.137 kHz
     Read little endian: 340.408 kHz

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ben-craig/thrift THRIFT-3217

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/537.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #537
    
----
commit 6debe734da89209d9e25a5380aa674ad744ad193
Author: Ben Craig <bencr...@apache.org>
Date:   2015-07-02T18:45:31Z

    Added little endian binary protocol

----


> Provide a little endian variant of the binary protocol in C++
> -------------------------------------------------------------
>
>                 Key: THRIFT-3217
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3217
>             Project: Thrift
>          Issue Type: Improvement
>    Affects Versions: 0.9.3
>            Reporter: Ben Craig
>
> Most computers these days are little endian.  With Thrift's current binary 
> protocol, we end up adjusting endianness on both sides of the connection most 
> of the time.  We should provide a variant that is optimized for the common 
> case of little endian machines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to