[
https://issues.apache.org/jira/browse/THRIFT-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613092#comment-14613092
]
Claudius Heine commented on THRIFT-2872:
----------------------------------------
Patch looks good, applies and compiles. "make cross" and "make check" report no
unexpected errors.
I see no issue with it. Ready to merge imo.
> ThreadManager deadlock for task expiration
> ------------------------------------------
>
> Key: THRIFT-2872
> URL: https://issues.apache.org/jira/browse/THRIFT-2872
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Reporter: Qiao Mu
> Attachments: 0001-Fix-dead-lock-when-all-tasks-are-expired.patch
>
>
> I have a TNonblockingServer running with 1 worker thread and 10 IO thread.
> If there was a big task that just finished, all pending tasks might be
> expired. In such case, all IO threads are waiting for maxMonitor_, but the
> worker won't notify. It will remove all the tasks(all of them are expired)
> first. And then the notify code won't be executed because tasks are empty.
> Deadlock occurs.
> The patch move the if-notify statement out so it will notify even if all
> tasks are removed for expiration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
