[ 
https://issues.apache.org/jira/browse/THRIFT-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623886#comment-14623886
 ] 

Kaspar Fenner commented on THRIFT-3222:
---------------------------------------

Thanks very much for the patch.
The change looks good, quotes are definitely not required there. In Visual 
Studio 2013/2015 and obviously also in the compiler itself, it seems not to be 
an issue, though.
[~roger.meier] can you pick it up for integration?

> TypeScript: Generated Enums are quoted
> --------------------------------------
>
>                 Key: THRIFT-3222
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3222
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Compiler
>            Reporter: Felipe Barriga Richards
>              Labels: typescript
>         Attachments: 0001-TypeScript-Fix-enum-generation-remove-quotes.patch
>
>
> Currently the generated enums looks like:
> {code}
> enum Foo {
>    'A' = 0,
>    'B'=1,
>    'C'=2
> }
> {code}
> And they should be:
> {code}
> enum Foo {
>    A = 0,
>    B = 1,
>    C = 2
> }
> {code}
> With this change WebStorm is able to autofill the values of the enum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to