[
https://issues.apache.org/jira/browse/THRIFT-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627058#comment-14627058
]
ASF GitHub Bot commented on THRIFT-3243:
----------------------------------------
Github user abhinav commented on the pull request:
https://github.com/apache/thrift/pull/550#issuecomment-121391999
This isn't the right way to do this
> Possible socket leak in THttpClient
> -----------------------------------
>
> Key: THRIFT-3243
> URL: https://issues.apache.org/jira/browse/THRIFT-3243
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Reporter: Abhinav Gupta
> Priority: Minor
>
> In THttpClient, the system does not close an HTTP connection until a
> consecutive request is made:
> def flush(self):
> if self.isOpen():
> self.close()
> self.open()
> If the THttpClient is discarded right after making a request, it will leave
> the connection open until it's garbage collected. It will be safer to close
> the connection after making the request.
> Pull request upcoming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
