GitHub user simonsouth opened a pull request:
https://github.com/apache/thrift/pull/573
THRIFT-3260 multiple warnings in c glib tutorial
Here are additional changes that should really and truly resolve all the
warnings generated when building the c_glib tutorial:
Compiler
- Do not output a trailing comma in exception-enum definitions.
- Move variable declarations to avoid mixing declarations and code in
generated code.
- Improve the readability of affected code blocks (and rely on indent_up
and indent_down for indentation).
Library
- Use only C-style comments in headers included by clients.
Tutorial
- Move THRIFT_UNUSED_VAR calls to avoid mixing declarations and code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simonsouth/thrift
thrift-3260-multiple-warnings-in-c_glib-tutorial
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #573
----
commit 5359a2432c0b67b8756e1cd964054ee3f4adb46f
Author: Simon South <[email protected]>
Date: 2015-07-28T10:48:55Z
c_glib: Compiler: Omit spurious ";" after GObject type macros
commit 99b60a1aaf9356fbd1e02f63fb7c3c1e9a0061b0
Author: Simon South <[email protected]>
Date: 2015-07-28T10:57:37Z
c_glib: Compiler: Suppress unused-var warnings in client initializers
commit 344998fbdcdb3bf23a593a5983a4658d7a29d921
Author: Simon South <[email protected]>
Date: 2015-07-28T11:53:33Z
c_glib: Tutorial: Remove spurious ";" from GObject type macro
commit c40ac038e349167fc870af5d3de4ed471d0cf037
Author: Simon South <[email protected]>
Date: 2015-07-28T15:06:39Z
c_glib: Tutorial: Silence unused-function warnings
commit 8ff3674b068e1edd1d701d6390ac9c90122e7230
Author: Simon South <[email protected]>
Date: 2015-07-31T08:52:39Z
c_glib: Do not use C++-style comments in library headers
commit 77f5ecece7256ce5ce1a2c5042a791d77b476677
Author: Simon South <[email protected]>
Date: 2015-07-31T09:33:55Z
c_glib: Compiler: Omit superfluous comma from generated enum
commit c639c4c2b0c0a791e51338e468eaf89b84192571
Author: Simon South <[email protected]>
Date: 2015-07-31T09:39:25Z
c_glib: Compiler: Beautify code changed in previous commit
commit 6fbc0714ff300f66b0df66852cf350f04053b72b
Author: Simon South <[email protected]>
Date: 2015-07-31T10:16:32Z
c_glib: Compiler: Beautify code changed in previous commit
commit 0ac6c5c7ff31b2b1364b13646f63d85645dfc2d3
Author: Simon South <[email protected]>
Date: 2015-07-31T10:23:22Z
c_glib: Compiler: Don't mix declarations, code in generated code
commit 10233cc727142906ebc86a51d1ee9d05d4e0b42e
Author: Simon South <[email protected]>
Date: 2015-07-31T10:24:34Z
c_glib: Tutorial: Don't mix declarations, code
commit 543179a9ad2b04647ed1a9d0e1961b7214753b40
Author: Simon South <[email protected]>
Date: 2015-07-31T10:28:59Z
c_glib: Compiler: Beautify code changed in previous commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
