[
https://issues.apache.org/jira/browse/THRIFT-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649125#comment-14649125
]
ASF GitHub Bot commented on THRIFT-3283:
----------------------------------------
GitHub user simonsouth opened a pull request:
https://github.com/apache/thrift/pull/574
THRIFT-3283: c_glib: Tutorial: Fix uninitialized-variable warning
This patch makes the tutorial server initialize an error variable to NULL
before using it, which resolves a GLib warning printed to the console when the
server terminates.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simonsouth/thrift
thrift-3283-c_glib-tutorial-server-always-exits-with-warning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/574.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #574
----
commit 674ac3872c74cf38a68cc9f1437716523a65b22f
Author: Simon South <sso...@simonsouth.com>
Date: 2015-07-31T11:57:43Z
c_glib: Tutorial: Fix uninitialized-variable warning
----
> c_glib: Tutorial server always exits with warning
> -------------------------------------------------
>
> Key: THRIFT-3283
> URL: https://issues.apache.org/jira/browse/THRIFT-3283
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.9.3
> Environment: Cloud9 (Ubuntu 14.04.2 LTS; gcc 4.8.2)
> Reporter: Simon South
> Assignee: Simon South
> Priority: Minor
> Labels: c_glib, tutorial
>
> When terminating the C (GLib) tutorial server with Ctrl-C, this message is
> output to the console:
> {code}
> (process:18038): GLib-WARNING **: GError set over the top of a previous
> GError or uninitialized memory.
> This indicates a bug in someone's code. You must ensure an error is NULL
> before it's set.
> The overwriting error message was: failed to accept connection - Interrupted
> system call
> done.
> {code}
> The server should instead exit quietly without reporting an issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
