[
https://issues.apache.org/jira/browse/THRIFT-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652582#comment-14652582
]
Hudson commented on THRIFT-3288:
--------------------------------
SUCCESS: Integrated in Thrift #1637 (See
[https://builds.apache.org/job/Thrift/1637/])
THRIFT-3288 c_glib: Unit tests: Enable warnings, improve automake-variable use
(roger: rev db3646faefcd78cebd9f3f288b71590d2d765574)
* lib/c_glib/test/Makefile.am
THRIFT-3288 c_glib: Compiler: Don't mix declarations and code (roger: rev
c83a2b5185799f287f1548e0dc21c4cdb7bba6cd)
* compiler/cpp/src/generate/t_c_glib_generator.cc
THRIFT-3288 c_glib: Compiler: Silence unused-parameter warnings (roger: rev
7bc907a95931985792e11713eb38244259f1b926)
* compiler/cpp/src/generate/t_c_glib_generator.cc
THRIFT-3288 c_glib: Build unit tests without compiler warnings (roger: rev
38e7155c039f1dba6dd73a3114dd3a5ac7052418)
* lib/c_glib/test/testtransportsocket.c
* lib/c_glib/test/testframedtransport.c
* lib/c_glib/test/testbufferedtransport.c
* lib/c_glib/test/testoptionalrequired.c
* lib/c_glib/test/testsimpleserver.c
* lib/c_glib/test/testthrifttestclient.cpp
* lib/c_glib/test/testbinaryprotocol.c
* lib/c_glib/test/teststruct.c
THRIFT-3288 c_glib: Compiler: Gently refactor functions (roger: rev
b28e3ccdcbd31ff4975f9b22c3d6622b7d35bb21)
* compiler/cpp/src/generate/t_c_glib_generator.cc
> c_glib: Build unit tests with all warnings enabled, no warnings generated
> -------------------------------------------------------------------------
>
> Key: THRIFT-3288
> URL: https://issues.apache.org/jira/browse/THRIFT-3288
> Project: Thrift
> Issue Type: Improvement
> Components: C glib - Library
> Affects Versions: 0.9.3
> Environment: Cloud9 (Ubuntu 14.04.2 LTS; gcc 4.8.2)
> Reporter: Simon South
> Assignee: Simon South
> Priority: Minor
> Labels: c_glib, unit-test
> Fix For: 0.9.3
>
>
> For correctness and to help with tracking down bugs, the C (GLib) unit tests
> (in {{lib/c_glib/test}}) should build with the same compiler-warning options
> enabled for the C++ library's tests ({{-Wall -Wextra -pedantic}}) and without
> any warnings generated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
