[ https://issues.apache.org/jira/browse/THRIFT-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698715#comment-14698715 ]
ASF GitHub Bot commented on THRIFT-3296: ---------------------------------------- GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/587 THRIFT-3296 - Go cross test does not conform to spec You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3296 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/587.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #587 ---- commit 9b8cf19c6b48bfbcbc6cee75a4d40bbf1720c6c5 Author: Nobuaki Sukegawa <nsu...@gmail.com> Date: 2015-08-16T06:42:58Z THRIFT-3296 - Go cross test does not conform to spec ---- > Go cross test does not conform to spec > -------------------------------------- > > Key: THRIFT-3296 > URL: https://issues.apache.org/jira/browse/THRIFT-3296 > Project: Thrift > Issue Type: Bug > Components: Go - Library, Test Suite > Reporter: Nobuaki Sukegawa > > Currently Go cross test has following problems > * Client TestException should not assume exception TypeId according to > ThriftTest.thrift comment > * Client insanity test is missing > * Server insanity test is missing > It turned out that Go implementation conformance has been quite good. > After applying the patch, cross test result is almost as good as cpp and java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)