Hi there, I see that the package.json for 0.9.2:

https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=lib/nodejs/package.json;hb=refs/heads/0.9.2

is quite a bit different from what is in HEAD:

https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=package.json;hb=refs/heads/master

This is a long shot, but would it be possible to build off the 0.9.2 branch and 
just move “nodeunit@~0.8.0” from “dependencies” to “devDependencies” and 
release that as 0.9.3?

Currently, nodeunit@0.8.8 depends on tap@>=0.2.3, which (as of some time 
today?) on our system pulls in tap@1.3.3, which depends on 
deep-equal@1.0.99999. According to `npm info deep-equal`, version 1.0.99999 
does not exist. Apparently this works because of:

https://github.com/isaacs/node-tap/commit/994b64bc6465c7950f4a4bec3ed1f9f271090666

which tells node-tap@1.3.3 to use some patched version of deep-equal that is 
checked into the node-tap repository.

When we pulled in tap@1.3.2, then it depended on deep-equal@^1.0.0 and 
everything worked as intended.

But really, a release version of thrift@0.9.2 does not appear to have any 
runtime dependency on nodeunit, so it would be great to demote it to 
devDependencies.

Or I guess we just have to sit tight and wait until isaacs works things out 
with deep-equal and fixes tap…

Thanks if you got this far,
Michael

Reply via email to