[
https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727265#comment-14727265
]
ASF GitHub Bot commented on THRIFT-2850:
----------------------------------------
GitHub user snikulov opened a pull request:
https://github.com/apache/thrift/pull/598
cmake // fixes for std/boost::thread detection; security test; qt test
Hello All!
Relates to https://issues.apache.org/jira/browse/THRIFT-2850
1. Will use BOOST if not explicitly provided -DWITH_STDTHREADS=ON and
Boost_FOUND.
2. Will not build SecurityTest if NOT OPENSSL_FOUND (SecurityTest uses SSL
headers which is not available)
3. Fix for TQTcpServerTest_Qt5.
Build successful on Windows (MSVC 2013) and CentOS 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snikulov/thrift cmake_build_updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #598
----
commit b10dbb8a10e159af358585e0a5445b46e3e7094a
Author: Sergei Nikulov <sergey.niku...@gmail.com>
Date: 2015-09-02T10:06:22Z
fixes for std/boost::thread detection; security test; qt test
----
> CMake for Apache Thrift
> -----------------------
>
> Key: THRIFT-2850
> URL: https://issues.apache.org/jira/browse/THRIFT-2850
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Environment: all platforms
> Reporter: Roger Meier
> Assignee: Roger Meier
> Labels: cmake, travis
> Attachments: 0001-THRIFT-2850-CMake-for-Apache-Thrift.patch,
> THRIFT-2850_change_name_add_test_py.patch
>
>
> Goal: Extend Apache Thrift's *make cross* approach to the build system.
> Due to growing the field of operating system support, a proper executable
> and library detection mechanism running on as much platforms as possible
> becomes required. The other aspect is simplify the release process and
> package generation process.
> As nice side benefit of CMake is the generation of development environment
> specific solution files(VisualStudio, Eclipse, Xcode, etc. ). => No solution
> files within source tree.
> We are already building Apache Thrift with CMake for Linux-ARM, Linux-x86,
> Windows CE and Windows.
> We are in preparation phase for a pull request here:
> https://github.com/siemens/thrift/commits/cmake-master
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
