AW: [jira] [Created] (THRIFT-3314) Dots in file names of includes causes dots in javascript variable names

[Jens Geyer]

This is part of a bigger problem. Spaces in filenames are valid too, to name 
only one.
________________________________
Von: Matt Fysh (JIRA)
Gesendet: 04.09.2015 04:43
An: dev@thrift.apache.org
Betreff: [jira] [Created] (THRIFT-3314) Dots in file names of includes causes 
dots in javascript variable names

Matt Fysh created THRIFT-3314:
---------------------------------

             Summary: Dots in file names of includes causes dots in javascript 
variable names
                 Key: THRIFT-3314
                 URL: https://issues.apache.org/jira/browse/THRIFT-3314
             Project: Thrift
          Issue Type: Bug
            Reporter: Matt Fysh


Hi there,

{code:title=a.thrift}
include "b.c.thrift"
{code}

{code:title=b.c.thrift}
# nada
{code}

{{$ thrift -r --gen js:node a.thrift}}

{code:title=gen-nodejs/a_types}
//
// Autogenerated by Thrift Compiler (0.9.2)
//
// DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
//
var thrift = require('thrift');
var Thrift = thrift.Thrift;
var Q = thrift.Q;

var b.c_ttypes = require('./b.c_types')


var ttypes = module.exports = {};

{code}

One variable in the auto-generated thrift output contains a dot, which is not 
valid JavaScript and will not compile.

Cheers,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)