Huahang Liu created THRIFT-3345: ----------------------------------- Summary: Client connection not closed properly when a java.lang.Error is thrown Key: THRIFT-3345 URL: https://issues.apache.org/jira/browse/THRIFT-3345 Project: Thrift Issue Type: Bug Components: Java - Library Affects Versions: 0.9.2, 0.9.1, 0.5 Reporter: Huahang Liu Priority: Critical
When a java.lang.Exception is thrown in a thrift server method, client connections get closed properly. Please see the clean up code below. https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L300 But if a java.lang.Error is thrown, that block of clean up code won't be executed and thus client connections may block indefinitely. I think the clean up code show be move to a finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)