Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/620#discussion_r40163238
  
    --- Diff: lib/cpp/test/SecurityTest.cpp ---
    @@ -75,13 +75,17 @@ struct GlobalFixture
                 if (!boost::filesystem::exists(certFile("server.crt")))
                 {
                     keyDir = 
boost::filesystem::path(master_test_suite().argv[master_test_suite().argc - 1]);
    -                
BOOST_REQUIRE_MESSAGE(boost::filesystem::exists(certFile("server.crt")),
    -                                      "The last argument to this test must 
be the directory containing the test certificate(s).");
    +                if (!boost::filesystem::exists(certFile("server.crt")))
    +                {
    +                   std::cerr << "The last argument to this test must be 
the directory containing the test certificate(s)." << std::endl;
    --- End diff --
    
    Starting with boost-1.59 you cannot use assertion test macros outside a 
test scope.  This means you cannot use them in the global fixture.  It's a 
weird choice but that's why I made this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to