Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/608#issuecomment-142721161
  
    Hi, some comments.
    
    * Version numbers should match the Thrift version number.
    * They also need to be  mentioned in the "how to release" docs, see 
website, but that can be done later.
    * All (textual) files must have an ASF license header. This also includes 
shell scripts etc.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to