[
https://issues.apache.org/jira/browse/THRIFT-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933228#comment-14933228
]
ASF GitHub Bot commented on THRIFT-3360:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/629
THRIFT-3360 Improve cross test servers and clients further
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3360
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/629.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #629
----
commit 63fb5e5e5c5f2fe4e8fb602c7aceec53ec50c30c
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-09-23T16:39:05Z
THRIFT-3360 Improve cross test servers and clients further
----
> Improve cross test servers and clients further
> ----------------------------------------------
>
> Key: THRIFT-3360
> URL: https://issues.apache.org/jira/browse/THRIFT-3360
> Project: Thrift
> Issue Type: Bug
> Reporter: Nobuaki Sukegawa
>
> This is follow up fixes to THRIFT-3347
> All except C# cross tests in tests.json are mostly fixed now.
> h3. Java
> * Add missing client calls
> * Add missing client assersions
> * Semantic return code
> * Fix insane server handler
> Note that because of newly introduced Java testBinary and assertions, many
> failures are discovered and listed.
> Binary incompatibility is tracked in THRIFT-3359 and I'm working on it.
> h3. Python
> * Fix testException
> * Add testMultiException
> h3. Javascript
> * Fix testInsanity
> h3. C++
> * Do not return "basic type error" when connection etc. failed
> h3. c_glib
> * Fix client testInsanity (I forgot to include this to THRIFT-3347)
> * Fix server insane handler
> h3. Return code
> I want to introduce new semantice return values, so updated test/README.md in
> the pull request.
> The timeout bit is already used by test.py.
> {quote}
> + #define TEST_UNKNOWN 64 // 0100 0000 (Failed to prepare
> environemt etc.)
> + #define TEST_TIMEOUT 128 // 1000 0000
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
