[
https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933879#comment-14933879
]
James E. King, III commented on THRIFT-2242:
--------------------------------------------
It looks like there are two different issues in the original description.
1. Use unordered_map instead of map, use unordered_set instead of set.
This does not make sense. Many implementations are likely to depend on the
ordering that the current containers provide, and changing them would not be
compatible.
2. Use a native shared_ptr for the compiler.
On the issue of boost::shared_ptr vc. std::shared_ptr I can understand that,
however it would make more sense to have a Jira backlog item that describes,
"Eliminate the need for Boost when using C++11 or later". I believe that it is
likely possible to eliminate boost from the runtime library and distributed
headers through a cmake-time or autoconf-time configuration flag. That is
already described in THRIFT-2241, which is linked to this. Perhaps these two
tickets should be merged and the ultimate goal would be to meet the proposed
backlog summary text instead.
> Generate C++11 code
> -------------------
>
> Key: THRIFT-2242
> URL: https://issues.apache.org/jira/browse/THRIFT-2242
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Reporter: Vitali Lovich
>
> unordered_map instead of map, unordered_set instead of set, noexcept instead
> of throw() (unless the exact semantics of throw() are needed which seems
> unlikely).
> It should use the shared_ptr implementation that the library is configured
> with.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
