[ https://issues.apache.org/jira/browse/THRIFT-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939005#comment-14939005 ]
Hudson commented on THRIFT-3361: -------------------------------- SUCCESS: Integrated in Thrift #1673 (See [https://builds.apache.org/job/Thrift/1673/]) THRIFT-3361 Improve C# library Client: C# Patch: Nobuaki Sukegawa (jensg: rev 178b813acd6dd3e334b88386be938415d9f3bf97) * lib/csharp/test/ThriftTest/Makefile.am * test/tests.json * lib/csharp/Makefile.am * lib/csharp/src/Transport/TTLSSocket.cs * lib/csharp/src/Transport/TBufferedTransport.cs * lib/csharp/test/ThriftTest/TestServer.cs * compiler/cpp/src/generate/t_csharp_generator.cc * lib/csharp/test/ThriftTest/Program.cs * lib/csharp/test/ThriftTest/TestClient.cs * lib/csharp/src/Transport/TTransport.cs * test/known_failures_Linux.json * lib/csharp/src/Transport/TFramedTransport.cs THRIFT-3361 Improve C# library Client: C# Patch: Jens Geyer (jensg: rev 96409d9dfecd8213726ee83ff1ac40695f8eeeec) * lib/csharp/src/Transport/TFramedTransport.cs * lib/csharp/src/Transport/TBufferedTransport.cs > Improve C# library > ------------------ > > Key: THRIFT-3361 > URL: https://issues.apache.org/jira/browse/THRIFT-3361 > Project: Thrift > Issue Type: Improvement > Components: C# - Compiler, C# - Library, Test Suite > Reporter: Nobuaki Sukegawa > Assignee: Nobuaki Sukegawa > Fix For: 0.9.4 > > Attachments: 0001-THRIFT-3361-Improve-C-library.patch > > > h3. Server exception handling > Servers didn't propagate exceptions in handler code to the client. > Same as THRIFT-3349 (python) and THRIFT-3335 (ruby) > h3. TBufferedTransport > System.IO.BufferedStream inside this transport made it strongly tied to > underlying transport's stream state. > More concretely, when used on top of TTLSSocket it crashed because underlying > SslStream is disposed by the socket while BufferedStream kept trying to touch > the disposed stream after that. > So I removed BufferedStream and made it use System.IO.MemoryBuffer instead. > * Can now work on top of TTLSSocket > * Underlying transport no longer needs to be a TStreamTransport > h3. TFramedTransport > It was allocating new MemoryBuffer for nealy every write and read of frames. > I made it allocate only once. > h3. JSONProtocol > * Can now handle Base64 with padding for binary fields (Fixes C# part of > THRIFT-3359) > h3. TTLSSocket > * Make client certificate optional > h3. Test > With this patch applied, all the cross test apps should be mostly valid. > * Fix SSL setup > * Semantic return code > * Add testException and testMultiException > * Add missing assertions -- This message was sent by Atlassian JIRA (v6.3.4#6332)