[ https://issues.apache.org/jira/browse/THRIFT-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943946#comment-14943946 ]
Jens Geyer edited comment on THRIFT-3367 at 10/5/15 8:12 PM: ------------------------------------------------------------- Sure. First of all, thanks for catching this. My comment refers to point 3 on the very top of the [HowToContribute|https://thrift.apache.org/docs/HowToContribute]-document, which basically says "create a JIRA ticket" for it. No big deal in this case (hence the smiley), but we like to have a JIRA ticket for each patch and pull request to track progress, who's responsible and to have a more detailed discussion about the issue. Last not least, this way the info will find its way into the changelog. was (Author: jensg): Sure. First of all, thanks for catching this. My comment refers to point 3 on the very top of the [https://thrift.apache.org/docs/HowToContribute|HowToContribute]-document, which basically says "create a JIRA ticket" for it. No big deal in this case (hence the smiley), but we like to have a JIRA ticket for each patch and pull request to track progress, who's responsible and to have a more detailed discussion about the issue. Last not least, this way the info will find its way into the changelog. > Fix bad links to coding_standards.md #634 > ------------------------------------------ > > Key: THRIFT-3367 > URL: https://issues.apache.org/jira/browse/THRIFT-3367 > Project: Thrift > Issue Type: Bug > Components: Website > Reporter: Jens Geyer > Assignee: Jens Geyer > Priority: Trivial > Fix For: 1.0 > > > GitHub user jimmynavio opened a pull request: > https://github.com/apache/thrift/pull/634 > Fix bad links to coding_standards.md > I noticed the other bad links to coding_standards.md had been fixed, and > somehow CONTRIBUTING.md was missed. This is bad news bears since > CONTRIBUTING.md is directly referenced by > https://thrift.apache.org/docs/HowToContribute - which means these are > currently broken on the live site. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/jimmynavio/thrift patch-1 > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/634.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #634 > > ---- > commit e0384be3d5a80b82d45271d5760da8ed8801e707 > Author: Paul Royer <wmpaulro...@gmail.com> > Date: 2015-10-05T19:03:06Z > Fix bad links to coding_standards.md > ---- > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- -- This message was sent by Atlassian JIRA (v6.3.4#6332)