[
https://issues.apache.org/jira/browse/THRIFT-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949605#comment-14949605
]
ASF GitHub Bot commented on THRIFT-3371:
----------------------------------------
GitHub user ppenenko opened a pull request:
https://github.com/apache/thrift/pull/637
THRIFT-3371
As for the test, I have added a new socket type to the suite named
"abstract" and it works if added to tests.json but I'm not sure how to only
enable it on Linux (and not say OS X) so I didn't enable it there.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sideeffects/thrift THRIFT-3371
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #637
----
commit f593ea9d891dd0742825e1a1935244c043d9c278
Author: pavlo <[email protected]>
Date: 2015-10-08T20:43:56Z
THRIFT-3371: added test for abstract namespace domain sockets.
commit b361c910851044fb6633764931e7a001b9c05151
Author: pavlo <[email protected]>
Date: 2015-10-08T20:48:45Z
THRIFT-3371 Abstract namespace Unix domain sockets broken in C++
----
> Abstract namespace Unix domain sockets broken in C++
> ----------------------------------------------------
>
> Key: THRIFT-3371
> URL: https://issues.apache.org/jira/browse/THRIFT-3371
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Linux
> Reporter: Pavlo Penenko
>
> According to http://man7.org/linux/man-pages/man7/unix.7.html :
> The socket's address in this namespace is given by the
> additional bytes in sun_path that are covered by the specified
> length of the address structure. (Null bytes in the name have no
> special significance.)
> This used to work after the THRIFT-1481 change because the structure was
> 0-initialized but was probably broken later in
> 3e50a9a1d01950f356242aaab0cbf5fae778b81c
> I have an abstract namespace unit test and a fix coming up on GitHub.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
