[ https://issues.apache.org/jira/browse/THRIFT-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950815#comment-14950815 ]
ASF GitHub Bot commented on THRIFT-3373: ---------------------------------------- GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/641 THRIFT-3373 Various fixes for cross test servers and clients You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3373 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/641.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #641 ---- commit 338f1a502961a4f63b0bd4b3dae4099062d6d17f Author: Nobuaki Sukegawa <nsu...@gmail.com> Date: 2015-10-09T17:25:18Z THRIFT-3373 Various fixes for cross test servers and clients ---- > Various fixes for cross test servers and clients > ------------------------------------------------ > > Key: THRIFT-3373 > URL: https://issues.apache.org/jira/browse/THRIFT-3373 > Project: Thrift > Issue Type: Bug > Components: Test Suite > Reporter: Nobuaki Sukegawa > > I hope it's the last time such a broad fix is needed on this. > * fix testBinary and testMultiException handler of c_glib server > * nodejs server testBinary handler was missing > * python and haskell lib names were incorrect in configure.ac (sorry about > that) > * Enable dart in make cross > * ruby clients did not disconnect from the server > Since many test servers use rudimentary TSimpleServer, it resulted in dead > locks > * nodejs clients only half-closed (no more send) the connection. > the same reason as the above, it resulted in hang. > (The patch simply makes it exit with 0 in the end.) > * python server did not log anything to files > * nodejs client assumed that map and set orders were preserved -- This message was sent by Atlassian JIRA (v6.3.4#6332)