Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/651#issuecomment-147880525 This change is needed on top of the existing PR to make the nodejs testsuite up and running again: ``` diff --git a/lib/nodejs/test/testAll.sh b/lib/nodejs/test/testAll.sh index 38b284a..417411b 100755 --- a/lib/nodejs/test/testAll.sh +++ b/lib/nodejs/test/testAll.sh @@ -23,8 +23,8 @@ fi DIR="$( cd "$( dirname "$0" )" && pwd )" -ISTANBUL="$DIR/../../../node_modules/istanbul/lib/cli.js" -RUNBROWSER="$DIR/../../../node_modules/run-browser/bin/cli.js" +ISTANBUL="$DIR/../node_modules/istanbul/lib/cli.js" +RUNBROWSER="$DIR/../node_modules/run-browser/bin/cli.js" REPORT_PREFIX="${DIR}/../coverage/report" ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---