Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/653#discussion_r42043446
--- Diff: compiler/cpp/src/generate/t_cpp_generator.cc ---
@@ -116,7 +116,8 @@ class t_cpp_generator : public t_oop_generator {
bool read = true,
bool write = true,
bool swap = false,
- bool stream = false);
+ bool stream = false,
+ bool is_struct = false);
--- End diff --
is this necessary? it's either struct or exception, and there is already
bool for that. or am I missing something? IMHO there is too many of those bools
already :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
