Hi All, Disappointingly - After submitting my first pull request, the Travis CI build has failed the following job: https://travis-ci.org/apache/thrift/jobs/87701328 I would have built this on Travis CI before creating a pull request, but I'd already pushed the code to my branch and there seems to be no way to trigger it manually.
Looking at the log file, it seems that clang died while building the core tests for C++ Does anyone know whether this test normally fails at the moment? make TestServer TestClient StressTest StressTestNonBlocking make[4]: Entering directory `/home/travis/build/apache/thrift/test/cpp' depbase=`echo src/TestServer.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ clang++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I/usr/include -I../../lib/cpp/src -Igen-cpp -Wall -Wextra -pedantic -g -O2 -std=c++11 -MT src/TestServer.o -MD -MP -MF $depbase.Tpo -c -o src/TestServer.o src/TestServer.cpp &&\ mv -f $depbase.Tpo $depbase.Po depbase=`echo src/TestClient.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ clang++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I/usr/include -I../../lib/cpp/src -Igen-cpp -Wall -Wextra -pedantic -g -O2 -std=c++11 -MT src/TestClient.o -MD -MP -MF $depbase.Tpo -c -o src/TestClient.o src/TestClient.cpp &&\ mv -f $depbase.Tpo $depbase.Po clang: error: unable to execute command: Killed clang: error: clang frontend command failed due to signal (use -v to see invocation) Thanks in advance Jonathan N.B. The full log is here: https://api.travis-ci.org/jobs/87701328/log.txt?deansi=true On 27/10/15 16:05, JonathanH-UK wrote: > GitHub user JonathanH-UK opened a pull request: > > https://github.com/apache/thrift/pull/663 > > Thrift 3397 > > 2 Commits for consideration: > 5cf0334 - Changes to C# Library Code (lib/csharp/src) > 024c204 - Supporting changes to C# Test Code (lib/csharp/test) > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/JonathanH-UK/thrift THRIFT-3397 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/thrift/pull/663.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #663 > > ---- > commit 5cf03343aa8c84ffdfc1d5ff36653bd51bfc5ebb > Author: Jonathan Heard <jonathan.he...@qassociates.co.uk> > Date: 2015-10-26T13:09:13Z > > THRIFT-3397 Implement TProcessorFactory in C# to enable per-client > processors > Created TProcessorFactory interface, implemented at > TSingletonProcessorFactory and TPrototypeProcessorFactory > Updated TServer + implementations to use the singleton factory by default > > Added new cs sources to Makefile.am > > commit 024c20441fd948017b9df455211f053acf86809d > Author: Jonathan Heard <jonathan.he...@qassociates.co.uk> > Date: 2015-10-26T18:15:21Z > > THRIFT-3397 Implement TProcessorFactory in C# to enable per-client > processors - Tests > > Modified TestClient so it only calls Open then Close on the first new > Transport (i.e. Client thread '-t n') instance > > Added a clientID counter to TestServer.cs to differntiate tests running > concurrently from different clients. > Added a logging delegate to TestServer.cs and refactored tests to use it > (implemented so it automatically prefixes the clientID to the output). > > Program.cs (Test Client and Server) - Set windows console height to > maximum and enlarge scrollback buffer on startup > > Removed testStop() method. It's unused and not in the ThriftTest.thrift > spec > > Implemented --server-type flag or C# TestServer in line with > test/README.md examples. Added '--processor' flag to enable selection of new > TPrototypeProcessorFactory (--prototype OR --processor=prototype) > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > This message includes information that we consider will be prejudicial to our commercial interests if it is disclosed. If, pursuant to the provisions of the Freedom of Information Act 2000 (or any subordinate legislation or codes of practice), you receive any request to disclose and/or intend to disclose all or any of the Information you agree that you will consult with us before disclosing any such Information. In so consulting you will act reasonably and in good faith and will duly consider any representations we may make relating to the proposed disclosure or otherwise of such Information. The information transmitted by this email is confidential and for the sole use of the intended recipient(s). If you are neither an intended recipient nor an employee or agent responsible for delivery to the intended recipient, you should be aware that any unauthorised review, use, disclosure or distribution is strictly prohibited. If you have received this message in error please immediately contact the sender by return email and delete the original message and destroy all copies thereof. Q Associates has taken every reasonable precaution to ensure that any attachment to this email has been checked for software viruses however the company cannot accept liability for any damages sustained as a result of a virus and would advise that you carry out your own virus checks before opening any attachment.