[
https://issues.apache.org/jira/browse/THRIFT-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987525#comment-14987525
]
ASF GitHub Bot commented on THRIFT-3409:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/681
THRIFT-3409 NodeJS binary field issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3409
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/681.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #681
----
commit b427f7e6dbec073f71c6af2c16de6e29d047dbcf
Author: Nobuaki Sukegawa <[email protected]>
Date: 2015-11-03T15:07:43Z
THRIFT-3409 NodeJS binary field issues
----
> NodeJS binary field issues
> --------------------------
>
> Key: THRIFT-3409
> URL: https://issues.apache.org/jira/browse/THRIFT-3409
> Project: Thrift
> Issue Type: Sub-task
> Components: Node.js - Library
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
>
> There's at least 3 problems in NodeJS binary field.
> # API are inconsistent across binary/comact/JSON protocols
> # compact/JSON wire format is imcompatible with other languages
> (JSON : THRIFT-3200)
> # size of compact wire format is 2x of the original binary
> I propose following changes to fix this
> # Change JSON protocol return value from string to Buffer (same as
> binary/compact)
> # Change JSON protocol wire format to Base64 (same as other languages)
> # Change compact protocol wire format to plain binary (same as other
> languages)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
