Github user jkrems commented on the pull request:
https://github.com/apache/thrift/pull/672#issuecomment-153830391
If it makes a difference - I already [signed the CLA before in a different
context](https://github.com/dscape/nano/issues/265#issuecomment-82564981). Not
sure if the process around this changed. In any case: Happy to accept the
contribution license.
For reference, these are the instructions for Github PRs:
* Create a fork for http://github.com/apache/thrift
* Create a branch for your changes(best practice is issue as branch name,
e.g. THRIFT-9999)
* Modify the source to include the improvement/bugfix
* Remember to provide tests for all submited changes
* When bugfixing: add test that will isolate bug before applying change
that fixes it
* Verify that you follow Thrift Coding Standards (you can run 'make style',
which ensures proper format for some languages)
* Verify that your change works on other platforms by adding a GitHub
service hook to Travis CI and AppVeyor
* Commit and push changes to your branch (please use issue name and
description as commit title, e.g. THRIFT-9999 make it perfect)
* Issue a pull request with the jira ticket number you are working on in
it's name
* Wait for other contributors or committers to review your new addition
* Wait for a committer to commit your patch
It doesn't look like those are mentioning any licensing topics. Admittedly
I ignored the JIRA parts because it felt like overkill for a small change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
