[ 
https://issues.apache.org/jira/browse/THRIFT-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001937#comment-15001937
 ] 

ASF GitHub Bot commented on THRIFT-3309:
----------------------------------------

GitHub user hush-hush opened a pull request:

    https://github.com/apache/thrift/pull/689

    THRIFT-3309: Missing TConstant.php in /lib/php/Makefile.am

    The file lib/php/lib/Thrift/Type/TConstant.php is missing from the php
    Makefile. Therefore "make install" don't copy the TConstant.php file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/leboncoin/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #689
    
----
commit a580438608a44cf97b12ee780928128fed32bb4a
Author: Maxime Mouial <maxime.mou...@scmfrance.fr>
Date:   2015-11-12T10:26:08Z

    THRIFT-3309: Missing TConstant.php in /lib/php/Makefile.am
    
    The file lib/php/lib/Thrift/Type/TConstant.php is missing from the php
    Makefile. Therefore "make install" don't copy the TConstant.php file.

----


> Missing TConstant.php in /lib/php/Makefile.am
> ---------------------------------------------
>
>                 Key: THRIFT-3309
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3309
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.9.2, 0.9.3, 0.9.4
>            Reporter: maxime mouial
>              Labels: build
>         Attachments: THRIFT-3309-missing_file_in_Makefile.patch
>
>
> The file *lib/php/lib/Thrift/Type/TConstant.php* is missing from the php 
> Makefile (lib/php/Makefile.am).
> Therefore "make install" don't copy the TConstant.php file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to